Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhance SAPHanaSR-showAttr version check #21138

Merged
merged 1 commit into from
Feb 11, 2025
Merged

Enhance SAPHanaSR-showAttr version check #21138

merged 1 commit into from
Feb 11, 2025

Conversation

lilyeyes
Copy link
Contributor

@lilyeyes lilyeyes commented Feb 7, 2025 •
edited
Loading

Enhance SAPHanaSR-showAttr version check

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 7, 2025

Great PR! Please pay attention to the following items before merging:

Files matching lib/**.pm:

  • Consider adding or extending unit tests in t/

This is an automatically generated QA checklist based on modified files.

@lilyeyes lilyeyes force-pushed the enhance-SAPHanaSR-showAttr-version branch 19 times, most recently from f5795eb to 3b8ce57 Compare February 8, 2025 10:27
@lilyeyes lilyeyes marked this pull request as ready for review February 10, 2025 03:07
@badboywj
Copy link
Contributor

LGTM, thanks

lpalovsky
lpalovsky approved these changes Feb 10, 2025
View reviewed changes
Copy link
Contributor

@lpalovsky lpalovsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

mpagot
mpagot reviewed Feb 10, 2025
View reviewed changes
lib/sles4sap_publiccloud.pm Outdated Show resolved Hide resolved
@mpagot
Copy link
Contributor

mpagot commented Feb 10, 2025

So the approach is to drop --version at all also for older SAPHanaSR-showAttr supporting it. Is it ok to do?

@lilyeyes
Copy link
Contributor Author

So the approach is to drop --version at all also for older SAPHanaSR-showAttr supporting it. Is it ok to do?

I think yes, this PR supports both version (old and new).

@lilyeyes
Enhance SAPHanaSR-showAttr version check
3f38f10 
TEAM-10057 - Latest SAPHanaSR-showAttr drop --version argument
@lilyeyes lilyeyes force-pushed the enhance-SAPHanaSR-showAttr-version branch from 3b8ce57 to 3f38f10 Compare February 10, 2025 10:17
alvarocarvajald
alvarocarvajald approved these changes Feb 10, 2025
View reviewed changes
Copy link
Contributor

@alvarocarvajald alvarocarvajald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I'm giving below a suggestion to combine 2 lines into one and drop a variable from the code, but it can also be merged as is if the current version is easier to read.

lib/sles4sap_publiccloud.pm Show resolved Hide resolved
@a-kpappas a-kpappas merged commit 7c3878f into os-autoinst:master Feb 11, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alvarocarvajald alvarocarvajald alvarocarvajald approved these changes

@mpagot mpagot mpagot left review comments

@lpalovsky lpalovsky lpalovsky approved these changes

@a-kpappas a-kpappas Awaiting requested review from a-kpappas a-kpappas is a code owner

@Amrysliu Amrysliu Awaiting requested review from Amrysliu Amrysliu is a code owner

@BillAnastasiadis BillAnastasiadis Awaiting requested review from BillAnastasiadis BillAnastasiadis is a code owner

@emiura emiura Awaiting requested review from emiura emiura is a code owner

@jankohoutek jankohoutek Awaiting requested review from jankohoutek jankohoutek is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@lilyeyes @badboywj @mpagot @alvarocarvajald @lpalovsky @a-kpappas