Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Add test for The Battle For Wesnoth #16539

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

clanig
Copy link
Contributor

@clanig clanig commented Mar 5, 2023

This is a draft, because it requires the following PR to be merged first: os-autoinst/os-autoinst#2276

This PR adds a test for The Battle for Wesnoth. It is a proof of concept for the feature string based OCR needles.
Compared with the previous attempt to merge a test for The Battle for Wesnoth, the number of needle images was reduced from 27 to 10 with the help of OCR, even though multiple game textures needed to be compared which can't be identified by OCR due to the nature of this program.

I have verified it on a development instance for os-autoinst.

In the picture below you can see how the matched OCR needles of the draft implementation of text based OCR are presented in the frontend, where no changes were applied yet. As you can see, there is no needle image displayed for comparison, instead just the screenshot and the match percentage is visible and the step is marked green.

image

tests/gaming/wesnoth.pm Outdated Show resolved Hide resolved
@clanig clanig force-pushed the add_battle_for_wesnoth_test branch from 1badb4b to 2468b29 Compare March 17, 2023 17:51
This commit adds a test for The Battle for Wesnoth.
The test is the first test based on text based OCR needles.
It checks the launch of the program, changing settings, starting a
new game, recruiting and moving units, saving and loading, finishing
the round and exiting the game.
@clanig clanig force-pushed the add_battle_for_wesnoth_test branch from 2468b29 to f63312f Compare March 17, 2023 18:01
@stale
Copy link

stale bot commented Jun 17, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.
If it's still needed, you can add labels WIP or notready to it

@stale stale bot added the stale Stale pull request, are to be deleted within 90 days label Jun 17, 2023
@clanig
Copy link
Contributor Author

clanig commented Jun 20, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. If it's still needed, you can add labels WIP or notready to it

I am working on it and have an version locally. I will push it when I push the other parts.

@stale stale bot removed the stale Stale pull request, are to be deleted within 90 days label Jun 20, 2023
Copy link

stale bot commented Dec 15, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.
If it's still needed, you can add labels WIP or notready to it

@stale stale bot added the stale Stale pull request, are to be deleted within 90 days label Dec 15, 2023
@clanig clanig added WIP Work in progress and removed stale Stale pull request, are to be deleted within 90 days labels Dec 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
WIP Work in progress
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants