Use signatures in OpenQA::WebAPI::Controller::Test #6234
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
perlpunk
reviewed
Feb 28, 2025
| @@ -113,10 +113,6 @@ sub referer_check ($self) { | |||
| return 1; | |||
| } | |||
|
|
|||
| sub list { | |||
There was a problem hiding this comment.
hm, I guess mojolicious finds the template automatically, and all this does page is doing ajax calls...
There was a problem hiding this comment.
right. So I deleted the empty method as I deemed it as not necessary. Of course the API route still exists. Full CI tests might tell us if that assumption is correction
okurz
force-pushed
the
enhance/signatures2
branch
from
3be8e07 to
859bb3e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.