Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show correct needle versions in test result step matches #6190

Merged
merged 1 commit into from
Feb 27, 2025

Conversation

asdil12
Copy link
Member

@asdil12 asdil12 commented Feb 19, 2025

This is a limited part of #5175
taken out to go step by step.

The needle version is only read from vars.json and only supports hashrefs - no branches/tags.
Network interaction by git on showing a needle is limited to the absolute minimum.
Also the needle editor is not changed, yet.

Ticket: https://progress.opensuse.org/issues/162035

Copy link

codecov bot commented Feb 19, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.00%. Comparing base (44a6d49) to head (df5890d).
Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff            @@
##           master    #6190    +/-   ##
========================================
  Coverage   99.00%   99.00%            
========================================
  Files         396      398     +2     
  Lines       39804    40012   +208     
========================================
+ Hits        39406    39614   +208     
  Misses        398      398            

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@asdil12 asdil12 closed this Feb 20, 2025
@asdil12 asdil12 force-pushed the needles_from_casedir branch from c068f84 to 6fbd2ed Compare February 20, 2025 16:09
@asdil12 asdil12 reopened this Feb 20, 2025
@asdil12 asdil12 force-pushed the needles_from_casedir branch 6 times, most recently from 245d59e to 11b4fa8 Compare February 21, 2025 14:39
@asdil12 asdil12 marked this pull request as ready for review February 24, 2025 09:47
@asdil12 asdil12 force-pushed the needles_from_casedir branch from 11b4fa8 to 1f6c050 Compare February 24, 2025 11:06
@asdil12 asdil12 force-pushed the needles_from_casedir branch from 1f6c050 to 48d46ff Compare February 24, 2025 14:17
@asdil12
Copy link
Member Author

asdil12 commented Feb 24, 2025

Tested manually and seems to work.

@Martchus
Copy link
Contributor

You could mention @sdclarke and me as co-authors in the commit message.

@asdil12 asdil12 force-pushed the needles_from_casedir branch from cde418f to 8f64c5b Compare February 25, 2025 09:47
@asdil12 asdil12 force-pushed the needles_from_casedir branch from 8f64c5b to 6534e64 Compare February 25, 2025 10:39
Copy link
Member

@okurz okurz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some minor style suggestions and there is uncovered code

@asdil12 asdil12 force-pushed the needles_from_casedir branch from 6534e64 to 35507b4 Compare February 26, 2025 13:13
Copy link
Member

@okurz okurz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@asdil12 asdil12 force-pushed the needles_from_casedir branch from 3ad6c8d to a6beed0 Compare February 26, 2025 13:19
Copy link
Contributor

@Martchus Martchus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See my previous in-line comment.

Maybe rebasing helps to avoid the failing cacheing.

@okurz
Copy link
Member

okurz commented Feb 26, 2025

I am ok to accept an incomplete patch coverage as exception but please ensure that all test code at least is covered, see the failed codecov/project/tests

@Martchus
Copy link
Contributor

Yes, the uncovered mocking is likely a leftover and not actually used anymore.

@asdil12 asdil12 force-pushed the needles_from_casedir branch 3 times, most recently from 591e9f2 to a23c7df Compare February 27, 2025 10:36
@asdil12 asdil12 force-pushed the needles_from_casedir branch 3 times, most recently from b7e82de to deffc92 Compare February 27, 2025 13:31
Co-authored-by: Scott Clarke <[email protected]>
Co-authored-by: Oliver Kurz <[email protected]>
Co-authored-by: Tina Müller (tinita) <[email protected]>
Co-authored-by: Liv Dywan <[email protected]>
Co-authored-by: Wabri <[email protected]>
Co-authored-by: Martchus <[email protected]>
@asdil12 asdil12 force-pushed the needles_from_casedir branch from 8d1d2c8 to df5890d Compare February 27, 2025 16:04
@mergify mergify bot merged commit d390472 into os-autoinst:master Feb 27, 2025
46 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants