-
Notifications
You must be signed in to change notification settings - Fork 213
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show correct needle versions in test result step matches #6190
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6190 +/- ##
========================================
Coverage 99.00% 99.00%
========================================
Files 396 398 +2
Lines 39804 40012 +208
========================================
+ Hits 39406 39614 +208
Misses 398 398 ☔ View full report in Codecov by Sentry. |
c068f84
to
6fbd2ed
Compare
245d59e
to
11b4fa8
Compare
11b4fa8
to
1f6c050
Compare
1f6c050
to
48d46ff
Compare
Tested manually and seems to work. |
You could mention @sdclarke and me as co-authors in the commit message. |
cde418f
to
8f64c5b
Compare
8f64c5b
to
6534e64
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
some minor style suggestions and there is uncovered code
6534e64
to
35507b4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://github.com/os-autoinst/openQA/pull/6190/files#r1969929906 and squash commits
3ad6c8d
to
a6beed0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See my previous in-line comment.
Maybe rebasing helps to avoid the failing cacheing.
I am ok to accept an incomplete patch coverage as exception but please ensure that all test code at least is covered, see the failed codecov/project/tests |
Yes, the uncovered mocking is likely a leftover and not actually used anymore. |
591e9f2
to
a23c7df
Compare
b7e82de
to
deffc92
Compare
Co-authored-by: Scott Clarke <[email protected]> Co-authored-by: Oliver Kurz <[email protected]> Co-authored-by: Tina Müller (tinita) <[email protected]> Co-authored-by: Liv Dywan <[email protected]> Co-authored-by: Wabri <[email protected]> Co-authored-by: Martchus <[email protected]>
8d1d2c8
to
df5890d
Compare
This is a limited part of #5175
taken out to go step by step.
The needle version is only read from vars.json and only supports hashrefs - no branches/tags.
Network interaction by git on showing a needle is limited to the absolute minimum.
Also the needle editor is not changed, yet.
Ticket: https://progress.opensuse.org/issues/162035