Avoid restricting /tests/…/asset/… needlessly
#6145
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Allow unauthorized access to `/tests/…/asset/…` even when `[auth] require_for_assets = 1` is configured because this route never returns any assets itself; it just redirects to `/assets/…` which will still require authorization * Allow making exceptions for authorized asset downloads on reverse proxy level without having to take `/tests/…/asset/…` into account as well * See https://progress.opensuse.org/issues/175902
okurz
approved these changes
Jan 29, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6145 +/- ##
=======================================
Coverage 98.99% 98.99%
=======================================
Files 396 396
Lines 39637 39637
=======================================
Hits 39237 39237
Misses 400 400 ☔ View full report in Codecov by Sentry. |
b10n1k
approved these changes
Jan 29, 2025
os-autoinst-bot
pushed a commit
to os-autoinst-bot/openQA
that referenced
this pull request
Jan 30, 2025
commit 0b3fff4 Merge: 81c208e 2c43580 Author: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> AuthorDate: Wed Jan 29 19:14:24 2025 +0000 Commit: GitHub <[email protected]> CommitDate: Wed Jan 29 19:14:24 2025 +0000 Merge pull request os-autoinst#6145 from Martchus/allow-asset-redirects Avoid restricting `/tests/…/asset/…` needlessly
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/tests/…/asset/…even when[auth] require_for_assets = 1is configured because this route never returns any assets itself; it just redirects to/assets/…which will still require authorization/tests/…/asset/…into account as well