openqa-cli: Avoid reading unexpectedly from STDIN #5894
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Avoid skipping the rest of a script when that script is invoked via `sh < …` and internally invokes openqa-cli (which in this case must not consume all remaining lines in that script) * Read only from STDIN if explicitly requested via `--data-file -` in consistency with curl (which also allows using `-` where a file can be specified to use STDIN) * See https://progress.opensuse.org/issues/160820
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5894 +/- ##
==========================================
- Coverage 98.72% 98.71% -0.01%
==========================================
Files 394 394
Lines 38659 38657 -2
==========================================
- Hits 38167 38162 -5
- Misses 492 495 +3 ☔ View full report in Codecov by Sentry. |
b10n1k
approved these changes
Aug 26, 2024
kalikiana
approved these changes
Aug 26, 2024
perlpunk
reviewed
Aug 26, 2024
| @@ -32,11 +29,10 @@ sub command ($self, @args) { | |||
|
|
|||
| @args = $self->decode_args(@args); | |||
| die $self->usage unless my $path = shift @args; | |||
| $data = $data_file eq '-' ? $self->data_from_stdin : path($data_file)->slurp if $data_file; | |||
There was a problem hiding this comment.
Maybe this should also be added to the documentation in line 124
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sh < …and internally invokes openqa-cli (which in this case must not consume all remaining lines in that script)--data-file -in consistency with curl (which also allows using-where a file can be specified to use STDIN)