Remove git fetch with destination refspec feature #5874
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
perlpunk
reviewed
Aug 20, 2024
perlpunk
reviewed
Aug 20, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5874 +/- ##
==========================================
- Coverage 98.51% 98.51% -0.01%
==========================================
Files 394 394
Lines 38737 38735 -2
==========================================
- Hits 38160 38158 -2
Misses 577 577 ☔ View full report in Codecov by Sentry. |
perlpunk
reviewed
Aug 21, 2024
b10n1k
changed the title
perlpunk
reviewed
Aug 21, 2024
|
This pull request is now in conflicts. Could you fix it? 🙏 |
perlpunk
reviewed
Aug 22, 2024
perlpunk
approved these changes
Aug 22, 2024
|
This pull request is now in conflicts. Could you fix it? 🙏 |
|
Sorry, we had to revert #5863 so I guess you need to resolve conflicts again... |
|
Or wait until we can reinstate the refactoring. Otherwise it'll be a back and forth which is probably not worth it. |
|
The refactoring will include some more changes which will cause more conflicts with this PR, so conflicts will appear in both cases possiibly |
As per git documentation the refspec can formed as <src>:<dst> but dst cannot use arbitrary expressions (SHA) but an actual ref must be named. Its usage in the `_git_clone` mistakely adds a SHA ref as destination creating a branch with its name, which is not supported by git. As far as now the feature is not used in OpenQA so it can be safely removed. https://progress.opensuse.org/issues/164937 Signed-off-by: ybonatakis <[email protected]>
kalikiana
approved these changes
Aug 22, 2024
perlpunk
approved these changes
Aug 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per git documentation the refspec can formed as : but dst cannot
use arbitrary expressions (SHA) but an actual ref must be named. Its usage
in the
_git_clonemistakely adds a SHA ref as destination creating a branchwith its name, which is not supported by git.
As far as now the feature is not used in OpenQA so it can be safely removed.
https://progress.opensuse.org/issues/164937