Add /job_groups/id/build_results API route

[perlpunk]

Issue: https://progress.opensuse.org/issues/152939

I moved _map_tags_into_build into the compute_build_results() function.

The command lime to get the last "published" build would look like this:

    openqa-cli api job_groups/1/build_results only_tagged=1 limit_builds=1 \
      | jq -r '[.build_results[] | select(.tag.description=="published") | select(.version=="Tumbleweed") | .build ][0]'

To only get the latest build:

    openqa-cli api job_groups/1/build_results  limit_builds=1| jq -r '[.build_results[] | .build ][0]'

Only normal groups are supported, not parent groups, to keep it simple. I can go though our logs to see if the group_overview.json is ever called for parent groups.

I am seeing a problem with the documentation display of the new function when getting a 404. The documentation for the new function is displayed for +/job_groups/<group_id:num>/jobs GET as well as +/job_groups/<group_id:num>/build_results.
Maybe a bug in how Mojolicious renders the pod. I can't see anything wrong there.

Also I found a misdocumented route. I will open a seperate PR.

Still need to document this somewhere.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (8c66280) 98.37% compared to head (2dd03be) 98.38%.

Additional details and impacted files

@@           Coverage Diff           @@
##           master    #5433   +/-   ##
=======================================
  Coverage   98.37%   98.38%           
=======================================
  Files         389      389           
  Lines       37769    37827   +58     
=======================================
+ Hits        37157    37215   +58     
  Misses        612      612           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[okurz]

+1

[Martchus]

openqa-cli api job_groups/1/build_results | jq -r '[.build_results[] | .build ][0]'

So the limit_builds parameter is not supported (as on the UI route like this: https://openqa.suse.de/group_overview/110?limit_builds=1)? It would make sense to support the same set of parameters:

openqa-cli api job_groups/1/build_results?limit_builds=1

EDIT: Looks like this would actually already work.

[perlpunk]

openqa-cli api job_groups/1/build_results?limit_builds=1

EDIT: Looks like this would actually already work.

I edited the commit message to include limit_builds

[AdamWill]

Two tests from this are failing in Fedora, for some reason. $t->json_is('/build_results/4/all_passed' => ''); in t/api/10-jobgroups.t and all_passed => '', in the is_deeply in t/api/04-jobs.t "json representation of group overview (actually not part of the API)" subtest both fail because it's coming out as '0' (or 0, or both...hard to say...thanks perl), not ''. I've no idea why. We have perl 5.40.0-509.fc41 and Mojolicious 9.37; no idea what else would be involved in the JSONification. I can just patch the expected result, I guess - functionally, '0' should behave the same as '', they both evaluate false in if checks, which is what this is used for - but it's weird.

[AdamWill]

Huh, this "fixes" it:

-    $build_res->{all_passed} = $build_res->{passed} + $build_res->{softfailed} >= $build_res->{total};
+    $build_res->{all_passed} = $build_res->{passed} + $build_res->{softfailed} >= $build_res->{total} ? "1" : "";

...weird.

[AdamWill]

Hmm, this feels very fuzzy. If I make the code into this:

$build_res->{all_passed} = $build_res->{passed} + $build_res->{softfailed} >= $build_res->{total} ? 1 : 0;

and then make the check this:

$t->json_is('/build_results/4/all_passed' => 0);

it passes, not surprisingly. But it also passes if I make the check this:

$t->json_is('/build_results/4/all_passed' => "0");

so it "is" both 0 and "0"? Hmm.

[AdamWill]

#5731