Fail early when attempting to clone a job with missing assets #5383
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Do the same check for assets we already do before restarting a job also
before cloning
* This is necessary because assets that do not exist anymore are not
returned by the job API anymore at all. Thus the clone script would
not even attempt to download them and also not fail early. (The error
about the missing asset would only occur when trying to run the job.)
* Do not fail on missing assets that are created by a parent job (when that
parent job is cloned as well)
* Allow to proceed via `--ignore-missing-assets` as it is already possible
for download errors that happen on the fly
* See https://progress.opensuse.org/issues/151522
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5383 +/- ##
=======================================
Coverage 98.36% 98.36%
=======================================
Files 389 389
Lines 37454 37488 +34
=======================================
+ Hits 36840 36874 +34
Misses 614 614 ☔ View full report in Codecov by Sentry. |
okurz
approved these changes
Dec 4, 2023
mimi1vx
approved these changes
Dec 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
--ignore-missing-assetsas it is already possible for download errors that happen on the fly