Show FQDN in VNC command if available via WORKER_HOSTNAME
#5379
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `WORKER_HOSTNAME` variable usually contains the worker host's FQDN so it makes sense to show it (instead of just the `host` column) in the VNC instruction. Related ticket: https://progress.opensuse.org/issues/151576
perlpunk
approved these changes
Nov 29, 2023
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5379 +/- ##
=======================================
Coverage 98.36% 98.36%
=======================================
Files 389 389
Lines 37445 37454 +9
=======================================
+ Hits 36831 36840 +9
Misses 614 614 ☔ View full report in Codecov by Sentry. |
mimi1vx
approved these changes
Nov 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
WORKER_HOSTNAMEvariable usually contains the worker host's FQDN so it makes sense to show it (instead of just thehostcolumn) in the VNC instruction.Related ticket: https://progress.opensuse.org/issues/151576