Fix force-restarting jobs when an advanced restarting option was chosen #5364
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Avoid the syntactic noise from using jQuery and just use the regular DOM API directly.
Appending the force-parameter doesn't work that easily when the URL already contains other parameters. So we need to take that case into account when adding the force-parameter. I made this fix in the context of working on https://progress.opensuse.org/issues/150917.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5364 +/- ##
=======================================
Coverage 98.32% 98.32%
=======================================
Files 389 389
Lines 37330 37333 +3
=======================================
+ Hits 36704 36707 +3
Misses 626 626 ☔ View full report in Codecov by Sentry. |
okurz
approved these changes
Nov 16, 2023
kalikiana
approved these changes
Nov 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Appending the force-parameter doesn't work that easily when the URL already contains other parameters. So we need to take that case into account when adding the force-parameter.
I made this fix in the context of working on https://progress.opensuse.org/issues/150917.