-
Notifications
You must be signed in to change notification settings - Fork 210
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for SSH Authentication to ObsRsync Plugin #5360
Conversation
One problem i'm seeing is that the URLs still use the Edit: |
Thanks @kraih, Leaving a note for all watchers (and updated the PR description too).
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please make sure this is tested against both
- build.opensuse.org
- build.suse.de
See https://app.circleci.com/pipelines/github/os-autoinst/openQA/12483/workflows/c08ea15d-a06f-46f6-ab2e-dc3f7a5cf878/jobs/116513 . We still need to install ssh-keygen for tests. I guess we already do a similar approach for other packages? Take a look how rsync is part of hard test dependencies put only recommended for installing on user systems. So in dependencies.yaml add the package to "devel_no_selenium_requires:" |
For new packages I think we just put them into https://github.com/os-autoinst/openQA/blob/master/tools/ci/ci-packages.txt without a version to make CI happy. The next dependency PR will add a version. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5360 +/- ##
==========================================
+ Coverage 98.32% 98.35% +0.03%
==========================================
Files 389 389
Lines 37330 37391 +61
==========================================
+ Hits 36704 36777 +73
+ Misses 626 614 -12 ☔ View full report in Codecov by Sentry. |
a5661c0
to
da55360
Compare
c590841
to
94d95f0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, the condition mentioned in my last review should be double-checked. (I might be wrong but we should at least double-check.)
87b3f46
to
d019776
Compare
d019776
to
c0ad220
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
content all good, commits need to be squashd
Squashd 🚀 |
5a32104
to
25ecefd
Compare
Heavily inspired by: - https://github.com/openSUSE/obs-build/blob/master/PBuild/SigAuth.pm - openSUSE/cavil@583009d - https://www.suse.com/c/multi-factor-authentication-on-suses-build-service/ Addresses poo#139073 - Add openssh to devel dependencies for OBSRsync. Co-authored-by: Martchus <[email protected]> Co-authored-by: Tina Müller (tinita) <[email protected]> Co-authored-by: Oliver Kurz <[email protected]>
25ecefd
to
b08b00c
Compare
Ok, nice. Even after squashing we normally keep starting the commit message with a verb in imperative. I would also rephrase it a bit: |
commit 0130cfb Merge: 90cbb53 b08b00c Author: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> AuthorDate: Thu Nov 16 17:38:09 2023 +0000 Commit: GitHub <[email protected]> CommitDate: Thu Nov 16 17:38:09 2023 +0000 Merge pull request os-autoinst#5360 from josegomezr/obs_rsync_ssh_auth Add support for SSH Authentication to ObsRsync Plugin
ObsRsync Plugin now supports the new authentication mechanism of Build Service.
Heavily inspired by:
Addresses poo#139073
Important: The production
openqa.ini
config must be updated.obs_rsync.project_status_url
must not include/public/
.