Make openqa-cli retry also on connection errors #5359
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
perlpunk
added a commit
to perlpunk/scripts
that referenced
this pull request
Nov 13, 2023
When making openqa-cli requests, we try to be more patient. os-autoinst/openQA#5359 Will make sure also connection timeouts will be retried. Issue: ihttps://progress.opensuse.org/issues/138545
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5359 +/- ##
=======================================
Coverage 98.32% 98.32%
=======================================
Files 389 389
Lines 37326 37330 +4
=======================================
+ Hits 36700 36704 +4
Misses 626 626 ☔ View full report in Codecov by Sentry. |
okurz
reviewed
Nov 13, 2023
t/43-cli-api.t
Outdated
| @@ -60,6 +60,7 @@ my @host = ('--host', $host); | |||
| # Default options for authentication tests | |||
| my @auth = ('--apikey', 'ARTHURKEY01', '--apisecret', 'EXCALIBUR', @host); | |||
|
|
|||
| $ENV{MOJO_CONNECT_TIMEOUT} = 1; | |||
There was a problem hiding this comment.
does this mean waiting 1s in tests additionally?
There was a problem hiding this comment.
Actually we don't need it. I think because "Connection refused" will return immediately in this case. So I removed it again.
perlpunk
added a commit
to perlpunk/scripts
that referenced
this pull request
Nov 13, 2023
When making openqa-cli requests, we try to be more patient. os-autoinst/openQA#5359 Will make sure also connection timeouts will be retried. Issue: https://progress.opensuse.org/issues/138545
There may be temporary network problems or an overloaded webui. In those cases we also want to retry. Issue: https://progress.opensuse.org/issues/138545
perlpunk
force-pushed
the
api-cli-retry
branch
from
5136bc4 to
901317e
Compare
kalikiana
approved these changes
Nov 14, 2023
Martchus
approved these changes
Nov 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There may be temporary network problems or an overloaded webui. In those cases we also want to retry.
Issue: https://progress.opensuse.org/issues/138545