Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update config.schema.json link #3881

Merged
merged 1 commit into from
Nov 8, 2024
Merged

Conversation

Laplace-Transformer
Copy link
Contributor

@Laplace-Transformer Laplace-Transformer commented Nov 7, 2024

The side https://www.ory.sh/docs/hydra/reference/configuration-editor is broken - see chrome F12 console.
Broken githubusercontent link. The link was generated by a bot, so I guess this PR is invalid?
Consider using https://raw.githubusercontent.com/ory/x/master/otelx/config.schema.json instead - currently they are identical.

Related issue(s)

Checklist

  • I have read the contributing guidelines.
  • I have referenced an issue containing the design document if my change
    introduces a new feature.
  • I am following the
    contributing code guidelines.
  • I have read the security policy.
  • I confirm that this pull request does not address a security
    vulnerability. If this pull request addresses a security vulnerability, I
    confirm that I got the approval (please contact
    [email protected]) from the maintainers to push
    the changes.
  • I have added tests that prove my fix is effective or that my feature
    works.
  • I have added or changed the documentation.

Further Comments

Broken githubusercontent link
Copy link

codecov bot commented Nov 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.29%. Comparing base (e278b40) to head (0279d02).
Report is 9 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3881      +/-   ##
==========================================
+ Coverage   73.28%   73.29%   +0.01%     
==========================================
  Files         139      139              
  Lines       10914    10934      +20     
==========================================
+ Hits         7998     8014      +16     
- Misses       2377     2384       +7     
+ Partials      539      536       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Laplace-Transformer Laplace-Transformer changed the title Update config.schema.json fix: update config.schema.json link Nov 8, 2024
@zepatrik zepatrik merged commit 825c24d into ory:master Nov 8, 2024
31 of 37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants