Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: invalid numerics notation in session data #3722

Closed
wants to merge 4 commits into from
Closed

fix: invalid numerics notation in session data #3722

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d6e4b57
Fix invalid numerics exponential notation
nekiro Feb 23, 2024
02bfaa4
Add helper to avoid repeated code in handlers
nekiro May 7, 2024
f992e81
Merge branch 'master' into fix/invalid-numerics-notation
nekiro May 7, 2024
fa2ed97
Ensure proper number format in AcceptOAuth2ConsentRequestSession
nekiro Jun 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions consent/handler.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -745,6 +745,7 @@ func (h *Handler) acceptOAuth2ConsentRequest(w http.ResponseWriter, r *http.Requ

var p flow.AcceptOAuth2ConsentRequest
d := json.NewDecoder(r.Body)
d.UseNumber()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will only fix it for this specific endpoint. Another way of solving this is to override MarshalJSON of flow.AcceptOAuth2ConsentRequest and similar methods.

Copy link
Author

@nekiro nekiro Mar 11, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think other "endpoints" have problems, this issue is specifically with the data saved into session. I didn't notice other places where this would be an issue.

Copy link
Author

@nekiro nekiro May 7, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, I added small helper and replaced occurrences of decode in several handlers. I'm not sure how can I use MarshalJSON methods with this change as there is only call to json.Marshal there.
I'm also not really a go developer, so I'm not used to work with this language.

d.DisallowUnknownFields()
if err := d.Decode(&p); err != nil {
h.r.Writer().WriteErrorCode(w, r, http.StatusBadRequest, errorsx.WithStack(err))
Expand Down
Loading