feat(query): support custom-fetch-hook #1632
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like build is failing? |
|
Thank you for nice enhance ! |
|
I've thought about this, and I'd like to have no |
|
@izumin5210 |
soartec-lab
reviewed
Sep 22, 2024
| if (mutator?.isHook) { | ||
| const fetchImplementationBody = `return ${operationName}(${fetchFnOptions});`; | ||
| fetchImplementation = `export const use${pascal(operationName)}Hook = (): (${args}) => ${retrunType} => { | ||
| const ${operationName} = ${mutator.name}<Awaited<${retrunType}>>(); |
There was a problem hiding this comment.
Since operationName is confusing, how about naming it something like customHook, customMutator, or mutator, which makes it clear that it is a custom hook?
Suggested change
| const ${operationName} = ${mutator.name}<Awaited<${retrunType}>>(); | |
| const customHook = ${mutator.name}<Awaited<${retrunType}>>(); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status
READY
Description
Currently, Orval generates broken code when
mutatoris customfetchclient hook.Todos
Steps to Test or Reproduce
You can check by using sample app.