Fix OLAF endless logging #29
Conversation
|
A list is an inefficient datatype to use for this kind of operation, you'll want to use a deque. Not only will it be more efficient, if you:
|
There was a problem hiding this comment.
Aside from the specific changes mentioned above and below, what's stopping us from pulling the logs directly from journalctl instead of maintaining our own parallel logs? journalctl --unit=oresat-c3d --boot=0 --lines=500 --reverse does the same as what this is doing.
| @@ -47,12 +55,6 @@ def on_loop(self): | |||
| self.sleep(0.1) | |||
|
|
|||
| def on_read_since_boot(self) -> str: | |||
There was a problem hiding this comment.
This callback should be part of LogServiceHandler and not LogsService. Beyond doing something involving logs they share no common interests. As an added bonus when this callback is part of LogServiceHandler, _logs no longer needs to be global.
|
|
||
| return ret | ||
| return "\n".join(reversed(_logs)) |
There was a problem hiding this comment.
_logs is accessed from multiple threads and therefore needs an associated lock to access it to be thread safe. If this callback becomes part of LogServiceHandler it can reuse the Handler's existing lock which is held when .emit() is called.
|
|
||
| def __init__(self, **kwargs): | ||
| super().__init__(**kwargs) | ||
| self.data = [] |
There was a problem hiding this comment.
I assume self.data was left over from trying to make this work without a global _logs? If on_read_since_boot is moved to this class then this can stay, otherwise the whole overridden __init__() can be removed. (I'd obviously prefer the former.)
Only keep the last 500 logs in RAM for the REST API to use.
fixes #25