Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bit plane encoder #18

Closed
wants to merge 34 commits into from
Closed

Bit plane encoder #18

wants to merge 34 commits into from

Conversation

kk60503
Copy link

@kk60503 kk60503 commented Sep 22, 2023

Still working on binding

Copy link
Member

@ryanpdx ryanpdx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, some clean up and changes to binding code needed.

olaf/bpe/bpe.cpp Outdated Show resolved Hide resolved
olaf/bpe/bpe.cpp Outdated Show resolved Hide resolved
olaf/bpe/bpe.cpp Outdated Show resolved Hide resolved
olaf/bpe/bpe.cpp Outdated Show resolved Hide resolved
olaf/bpe/bpe.cpp Outdated Show resolved Hide resolved
olaf/bpe/makefile Outdated Show resolved Hide resolved
olaf/bpe/source/cfc.py Outdated Show resolved Hide resolved
olaf/bpe/source/errorhandle.c Outdated Show resolved Hide resolved
olaf/bpe/makefile Outdated Show resolved Hide resolved
olaf/bpe/makefile Outdated Show resolved Hide resolved
Copy link
Member

@ryanpdx ryanpdx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Remove all .pyc files
  • move olaf/bpe/testing/ contents to the tests/bpe/
  • move all images out of the olaf/ dir
  • What are the GHplaceholder files

olaf/bpe/testing/test_bpe.py Outdated Show resolved Hide resolved
olaf/bpe/testing/test_bpe.py Outdated Show resolved Hide resolved
olaf/bpe/testing/test_bpe.py Outdated Show resolved Hide resolved
olaf/bpe/main_pybind.cpp Show resolved Hide resolved
olaf/bpe/testing/pixel_check.py Outdated Show resolved Hide resolved
olaf/bpe/testing/pixel_check.py Outdated Show resolved Hide resolved
@ryanpdx ryanpdx linked an issue Nov 14, 2023 that may be closed by this pull request
@ryanpdx
Copy link
Member

ryanpdx commented Nov 14, 2023

If you can, please try to squash some of your commits and update your comments to better reflect what changed in the commits.

Also run black and isort on your .py files.

Upload source program
# This is the 1st commit message:

Add files via upload
# This is the commit message #2:

Delete olaf/bpe directory
# This is the commit message #3:

Add files via upload
# This is the commit message #4:

Delete olaf/bpe_wd directory
# This is the commit message #5:

Delete olaf/bpe/setup.py
# This is the commit message #6:

Delete olaf/bpe/test.py
# This is the commit message #7:

Delete olaf/bpe/CMakeLists.txt
# This is the commit message #8:

Add files via upload
# This is the commit message #9:

Add files via upload
# This is the commit message #10:

Add files via upload
# This is the commit message #11:

Add files via upload
Delete olaf/bpe directory

Add files via upload

Delete olaf/bpe_wd directory

Delete olaf/bpe/setup.py

Delete olaf/bpe/test.py

Delete olaf/bpe/CMakeLists.txt

Add files via upload

Add files via upload

Add files via upload

Add files via upload

Delete olaf/bpe/makefile

Delete olaf/bpe/makefile

Delete olaf/bpe/source/UNL_readme_kielymods.rtf

Add files via upload

it works

Add files via upload

Did some thorough combing of source files. The py bpe is now functional. Will begin testing/debug

Delete olaf/imgs_raw directory

Delete olaf/bpe directory

Add files via upload

reupload (wrong dir)

Delete olaf/source directory

Delete olaf/test directory

Delete olaf/Makefile

Delete olaf/README.md

Delete olaf/bpe.cpp

Delete olaf/bpe_test.py

Delete olaf/main_pybind.cpp

Delete olaf/bpe/source/test directory

Delete olaf/bpe/source/imgs_raw directory

Delete olaf/bpe/imgs_raw/RR.out

Delete olaf/bpe/imgs_raw/sensin.out

Update ycol_global.h

Delete olaf/bpe/test/imgs_conv/sensin.img.png

Update README.md

Update README.md

Update Makefile
Delete olaf/bpe directory

Add files via upload

Delete olaf/bpe_wd directory

Delete olaf/bpe/setup.py

Delete olaf/bpe/test.py

Delete olaf/bpe/CMakeLists.txt

Add files via upload

Add files via upload

Add files via upload

Add files via upload

Delete olaf/bpe/makefile

Delete olaf/bpe/makefile

Delete olaf/bpe/source/UNL_readme_kielymods.rtf

Add files via upload

it works

Add files via upload

Did some thorough combing of source files. The py bpe is now functional. Will begin testing/debug

Delete olaf/imgs_raw directory

Delete olaf/bpe directory

Add files via upload

reupload (wrong dir)

Delete olaf/source directory

Delete olaf/test directory

Delete olaf/Makefile

Delete olaf/README.md

Delete olaf/bpe.cpp

Delete olaf/bpe_test.py

Delete olaf/main_pybind.cpp

Delete olaf/bpe/source/test directory

Delete olaf/bpe/source/imgs_raw directory

Delete olaf/bpe/imgs_raw/RR.out

Delete olaf/bpe/imgs_raw/sensin.out

Update ycol_global.h

Delete olaf/bpe/test/imgs_conv/sensin.img.png

Update README.md

Update README.md

Update Makefile
Add completed program and unittest for review
@kk60503 kk60503 closed this Dec 3, 2023
@kk60503 kk60503 deleted the bit_plane_encoder branch December 4, 2023 00:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

CCSDS image data compression module
2 participants