Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Terms from Issues -> PR #44

Closed
wants to merge 31 commits into from
Closed

Terms from Issues -> PR #44

wants to merge 31 commits into from

Conversation

Christian-MK
Copy link
Contributor

Contributors should not use the Issues section. This PR is for clearing out the proposed terms there at present

@Christian-MK
Copy link
Contributor Author

Terms included in the last commit
#4, #5, #11, #12, #22, #31, #32, #39

@ross-spencer ross-spencer changed the base branch from main to peterVG-patch-1 August 29, 2024 07:52
@ross-spencer ross-spencer changed the base branch from peterVG-patch-1 to main August 29, 2024 07:52
Copy link
Contributor

@waalge waalge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't sign off on these definitions.

These are general terms for which i am not aware we have any meaningful divergence from how they are generally understood. At worst I think we should cite external sources for them

API came up over as an issue cos there was disagreement over whether using the blockchain for the interface was an API, since it is more commonly used to refer to HTTP interfaces. (The answer is that it is unambiguously an API as API does not require HTTP.)
The definition given doesn't resolve the disagreement, and i don't think is nearly as clear as the one provided by a dictionary.

for accessing data or services and better enabling
inter-connectivity between components.
''' ;
skos:altLabel "application programming interface ".
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there any reason we are not just taking a dictionary definition for this?
image

@ross-spencer
Copy link
Member

Looking at revisiting this tomorrow or Monday depending on today's efforts.

One observation is the commit history here seems to be incorrect and it's not looking trivial to resolve conflicts on the command line. It might be that it was branched from one recently merged? (which is easily done).

I wonder, can you checkout main from fresh, and then add the new .ttl files into a new branch created from that? It should make review and merging easier.

@Christian-MK
Copy link
Contributor Author

One observation is the commit history here seems to be incorrect and it's not looking trivial to resolve conflicts on the command line. It might be that it was branched from one recently merged? (which is easily done).

ah yes, my bad. I'll get this moved over.
And will continue the conversation there

@Christian-MK
Copy link
Contributor Author

A new PR has been made
#46

@Christian-MK Christian-MK deleted the christian/glossary branch August 29, 2024 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants