Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create network folders for branch removal #1

Merged
merged 1 commit into from
Sep 25, 2024
Merged

Conversation

ross-spencer
Copy link
Member

We can manage this repo more effectively without using multiple branches. We use folders to delineate network instead. Mainnet and preview are the only ones used as preprod isn't being used in Orcfax deployments right now.

@george-orcfax @gchartier <-- preparing to make this change this week if possible. Let me know if you have any preferred ways for me to coordinate this.

Connected to: https://github.com/orcfax/issues/issues/197

We can manage this repo more effectively without using multiple
branches. We use folders to delineate network instead. Mainnet and
preview are the only ones used as preprod isn't being used in
Orcfax deployments right now.
Copy link
Contributor

@george-orcfax george-orcfax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just let me know when you merge it, so that I can change immediately the URL in the monitoring.

@ross-spencer
Copy link
Member Author

ross-spencer commented Sep 24, 2024

Thanks George!

@gchartier anything can be impacted your end?

@gchartier
Copy link

Looks great, just need to know when you plan to merge so I can push my code update to the index. 👌

@gchartier
Copy link

gchartier commented Sep 24, 2024

Actually, I just thought of something that would make sense to change now while we're at it:

If we plan to continue using this same repo moving forward and for different feed types in addition to CER feeds, then I think the name of the repo should probably not be cer-feeds.

Perhaps active-feeds or simply feeds would be a better name?

If we change the name then that makes the feeds folder in the repo redundant and can just have folders for each network at the top-level instead.

@ross-spencer ross-spencer merged commit 75e2c08 into main Sep 25, 2024
1 check passed
@ross-spencer ross-spencer deleted the dev/remove-branch branch September 25, 2024 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants