Adding AWS S3 Configuration Provider and AWS Secrets Manager Provider #135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oracle-contributor-agreement
bot
added
the
OCA Verified
psilberk
reviewed
Jan 17, 2025
ojdbc-provider-samples/src/main/java/oracle/jdbc/provider/aws/configuration/AwsS3Example.java
Outdated
Show resolved
Hide resolved
psilberk
reviewed
Jan 17, 2025
psilberk
reviewed
Jan 17, 2025
psilberk
reviewed
Jan 17, 2025
psilberk
reviewed
Jan 17, 2025
psilberk
reviewed
Jan 17, 2025
Changes to be committed: modified: ojdbc-provider-aws/pom.xml new file: ojdbc-provider-aws/src/main/java/oracle/jdbc/provider/aws/authentication/AwsAuthenticationMethod.java new file: ojdbc-provider-aws/src/main/java/oracle/jdbc/provider/aws/authentication/AwsBasicCredentialsFactory.java new file: ojdbc-provider-aws/src/main/java/oracle/jdbc/provider/aws/configuration/AWSAppConfigProvider.java new file: ojdbc-provider-aws/src/main/java/oracle/jdbc/provider/aws/configuration/AWSAppConfigurationURLParser.java new file: ojdbc-provider-aws/src/main/java/oracle/jdbc/provider/aws/configuration/AWSConfigurationParameters.java modified: ojdbc-provider-aws/src/main/resources/META-INF/services/oracle.jdbc.spi.OracleConfigurationProvider new file: ojdbc-provider-samples/src/main/java/oracle/jdbc/provider/aws/configuration/SimpleAWSAppConfigExample.java
ting-lan-wang
force-pushed
the
aws_provider_s3
branch
from
b5a9f95 to
c1286fc
Compare
|
@psilberk all the review comments has been addressed. |
psilberk
reviewed
Jan 21, 2025
fmeheust
reviewed
Jan 28, 2025
| AwsCredentials awsCredentials = getCredential(parameterSet); | ||
| // TODO: Access tokens expire. Does a TokenCredential internally cache one? | ||
| // If so, then return an expiring resource. | ||
| return Resource.createPermanentResource(awsCredentials, true); |
There was a problem hiding this comment.
Will fix this in the next commit
| .addParameter("value", SecretsManagerFactory.SECRET_NAME) | ||
| .addParameter("REGION", SecretsManagerFactory.REGION) | ||
| .addParameter("key_name", SecretsManagerFactory.KEY_NAME)) | ||
| .build(); |
There was a problem hiding this comment.
Why are some parameters in capitals but not all ?
There was a problem hiding this comment.
This parser is used by both AwsJsonSecretsManagerProvider and AwsSecretsManagerConfigurationProvider. The REGION is in upper case to follow the naming convention in AUTHENTICATION and the related parameters. The same logic applies to the other parameter in lower cases.
Here's an example of the password object in Json payload:
"password": {
"type": "awssecretsmanager",
"value": "db-password-us-east-1",
"authentication": {
"AWS_REGION": "us-east-1"
}
},The REGION parameter will be renamed to AWS_REGION in the next upload.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Combining the work by @psilberk into this branch.
This branch adds the following Configuration Providers for AWS Services: