Feat/pricer fixes #446
Closed
Feat/pricer fixes #446
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antoncoding
reviewed
Dec 7, 2021
antoncoding
approved these changes
Dec 7, 2021
aleone
approved these changes
Dec 8, 2021
haythemsellami
approved these changes
Dec 8, 2021
| @@ -26,7 +26,7 @@ To deploy a new `ChainlinkPricer.sol`, it is recommended to use the `deployChain | |||
| **Input** | |||
|
|
|||
| ```sh | |||
| truffle exec scripts/deployChainlinkPricer.js --network mainnet --controller 0x7d78c401c69c56cb21f4bf80c53afd92be0BBBBB --pool 0xc02aaa39b223fe8d0a0e5c4f27ead9083c7AAaaa --weth 0x5f4eC3Df9cbd43714FE2740f5E3616155cAGAGAG --oracle 0xef196aA0e3Cb8EA6d5720557C3B611Eff6OOOOOO --gasPrice 50000000000 | |||
| truffle exec scripts/deployChainlinkPricer.js --network mainnet --bot 0xfacb407914655562d6619b0048a612B1795dF783 --asset 0x2260FAC5E5542a773Aa44fBCfeDf7C193bc2C599 --aggregator 0xF4030086522a5bEEa4988F8cA5B36dbC97BeE88c --oracle 0x789cD7AB3742e23Ce0952F6Bc3Eb3A73A0E08833 --gasPrice 100000000000 | |||
There was a problem hiding this comment.
Is this command correct ?!
There was a problem hiding this comment.
yep! This was wrong before! :)
Comment on lines
+108
to
+112
|
|
||
| ## Verification of Contracts | ||
| ```sh | ||
| truffle run verify ChainlinkPricer@0x17FDF6cE88517bf0Cff19e014E509B543DD78432 --network mainnet | ||
| ``` |
There was a problem hiding this comment.
Why we are adding this to README ?
There was a problem hiding this comment.
because I imagine whoever wants to deploy also needs to verify right? Would you add it to packag.json instead? :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task: Pricer fixes
Enable anyone to set prices for all assets
In the setExpiryPriceInOracle function, if anyone is calling the function, checks that the expiryTimestamp is less than the expiry timestamp of the passed in roundId. Also checks that the expiryTimestamp is grater than the expiry timestamp of the previous roundId. This ensures that someone cannot pass in an old price or too new of a price.
Code