Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wstETH pricer #440

Merged
merged 20 commits into from
Aug 20, 2021
Merged

wstETH pricer #440

merged 20 commits into from
Aug 20, 2021

Conversation

haythemsellami
Copy link
Member

@haythemsellami haythemsellami commented Aug 11, 2021 •
edited
Loading

wstETH pricer

High Level Description

This PR add WstethPricer.sol to return the price of wstETH token in USD scaled by 8 decimals.

Code

  • Unit test 100% coverage
  • Does your code follow the naming and code documentation guidelines?

Documentation

  • Is your code up to date with the spec?
  • Have you added your tests to the testing doc?

@haythemsellami haythemsellami added the pricer Oracle pricer contract label Aug 17, 2021
@haythemsellami haythemsellami self-assigned this Aug 17, 2021
@haythemsellami haythemsellami mentioned this pull request Aug 17, 2021
Closed
4 tasks
@haythemsellami haythemsellami changed the title [WIP] stETH pricer wstETH pricer Aug 17, 2021
@haythemsellami
Copy link
Member Author

There is 66 files changed because of linting.

CruzMolina
CruzMolina reviewed Aug 18, 2021
View reviewed changes
Copy link
Contributor

@CruzMolina CruzMolina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly good to go, one optimization to make.

@CruzMolina CruzMolina self-requested a review August 18, 2021 19:26
CruzMolina
CruzMolina approved these changes Aug 18, 2021
View reviewed changes
Copy link
Contributor

@CruzMolina CruzMolina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@CruzMolina CruzMolina force-pushed the pricer/steth branch 3 times, most recently from 44bad23 to 25309b8 Compare August 18, 2021 21:13
@CruzMolina CruzMolina merged commit 6f4f969 into master Aug 20, 2021
@CruzMolina CruzMolina deleted the pricer/steth branch August 20, 2021 23:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aleone aleone aleone approved these changes

@CruzMolina CruzMolina CruzMolina approved these changes

@chudnov chudnov chudnov approved these changes

@aparnakr aparnakr aparnakr approved these changes

Assignees

@haythemsellami haythemsellami

Labels
pricer Oracle pricer contract
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@haythemsellami @aleone @CruzMolina @chudnov @aparnakr