Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chore: update docs #436

Closed
wants to merge 2 commits into from
Closed

Chore: update docs #436

wants to merge 2 commits into from

Conversation

haythemsellami
Copy link
Member

@haythemsellami haythemsellami commented Jun 27, 2021 •
edited
Loading

Chore: update docs

High Level Description

Update documentations.

Code

  • Unit test 100% coverage
  • Does your code follow the naming and code documentation guidelines?

Documentation

  • Is your code up to date with the spec?
  • Have you added your tests to the testing doc?

@haythemsellami haythemsellami self-assigned this Jun 27, 2021
CruzMolina
CruzMolina approved these changes Jun 28, 2021
View reviewed changes
Copy link
Contributor

@CruzMolina CruzMolina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

scripts/README.md
@@ -23,7 +23,7 @@ To deploy a new `ChainlinkPricer.sol`, it is recommended to use the `deployChain

**Input**
```sh
truffle exec scripts/deployChainlinkPricer.js --network mainnet --controller 0x7d78c401c69c56cb21f4bf80c53afd92be0BBBBB --pool 0xc02aaa39b223fe8d0a0e5c4f27ead9083c7AAaaa --weth 0x5f4eC3Df9cbd43714FE2740f5E3616155cAGAGAG --oracle 0xef196aA0e3Cb8EA6d5720557C3B611Eff6OOOOOO --gasPrice 50000000000
truffle exec scripts/deployChainlinkPricer.js --network mainnet --bot 0x7d78c401c69c56cb21f4bf80c53afd92be0BBBBB --asset 0xc02aaa39b223fe8d0a0e5c4f27ead9083c7AAaaa --aggregator 0x5f4eC3Df9cbd43714FE2740f5E3616155cAGAGAG --oracle 0xef196aA0e3Cb8EA6d5720557C3B611Eff6OOOOOO --gasPrice 50000000000
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what is meant by bot? defender bot?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CruzMolina CruzMolina CruzMolina approved these changes

@alexisgauba alexisgauba Awaiting requested review from alexisgauba

@antoncoding antoncoding Awaiting requested review from antoncoding

@aparnakr aparnakr Awaiting requested review from aparnakr

Assignees

@haythemsellami haythemsellami

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@haythemsellami @CruzMolina