Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce Controller bytecode size #433

Merged
merged 28 commits into from
Jun 24, 2021
Merged

Conversation

aleone
Copy link
Contributor

@aleone aleone commented Jun 23, 2021

Task: Feature Name:

High Level Description

  • Update Controller revert messages
  • Re-implement getVault() from v1.0.0
  • Add new function getVaultWithDetails() that return vault, vault type, latest vault update timestamp
  • Refactor getPayout()
  • Add _getOtokenDetails() that try to call Otoken.getOtokenDetails(), if fail call Otoken external functions one by one
  • Re-implement isSettlementAllowed() from v1.0.0
  • Add canSettleAssets, similar to isSettlementAllowed() but with different args
  • Refactor hasExpired()
  • Update redeeming and vault settling to work with Otoken implementation v1.0.0
  • Update MarginCalculator.sol to use _getOTokenDetail() and work with Otoken implementation v1.0.0
  • Update Actions.sol revert messages
  • Update MarginVault.sol revert messages
  • docs: update docs & diagrams

Code

  • Unit test 100% coverage
  • Does your code follow the naming and code documentation guidelines?

Documentation

  • Is your code up to date with the spec?
  • Have you added your tests to the testing doc?

@haythemsellami haythemsellami added the gamma-v2.0.0 Opyn partial collateralization label Jun 24, 2021
Copy link
Contributor

@CruzMolina CruzMolina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice work everyone!

@haythemsellami haythemsellami merged commit 67a2bff into master Jun 24, 2021
@haythemsellami haythemsellami deleted the feature/smallerByteCode branch June 24, 2021 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gamma-v2.0.0 Opyn partial collateralization
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants