Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update qfc.com.yaml #192

Merged
merged 1 commit into from
Feb 11, 2017
Merged

Update qfc.com.yaml #192

merged 1 commit into from
Feb 11, 2017

Conversation

stuartpb
Copy link
Member

No description provided.

@stuartpb
Copy link
Member Author

stuartpb commented Feb 11, 2017

Stray observations:

  • The registration has two junk checkboxes ("Sign me up for a bunch of junk" checkboxes on registration #175), one for promotions and one for tracking
  • ToC acceptance on registration is implicit
  • Registration requires zip or city+state to select preferred store
  • Password reset request stub does not appear to distinguish existing accounts from non-existent ones
  • Password reset submit stub links to signin
  • Password change is tied to email update, where both email forms are pre-filled and listed as required inputs
  • Password reset while logged in works identically to reset while signed out, you even end a stub linking to the "sign in" page even though you remain signed in
  • Not only do they not invalidate reset tokens after use (!), they appear to not send multiple reset emails! I requested a second one after requesting the first one (before using it), and only got the first one.
  • Changing a password through reset triggers a notification email. I don't think changing it via settings does, though. (Or I might have this backwards - but the bottom line is that I'm pretty sure only one or the other triggers the notification, not both.)

@stuartpb stuartpb merged commit 8c19da9 into master Feb 11, 2017
@stuartpb stuartpb deleted the qfc branch February 11, 2017 04:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant