Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build packages by Rollup instead of tsc #904

Closed
wants to merge 9 commits into from

Conversation

porink0424
Copy link
Collaborator

@porink0424 porink0424 commented Jul 12, 2024

Contributor License Agreement

This repository (optuna-dashboard) and Goptuna share common code.
This pull request may therefore be ported to Goptuna.
Make sure that you understand the consequences concerning licenses and check the box below if you accept the term before creating this pull request.

  • I agree this patch may be ported to Goptuna by other Goptuna contributors.

Reference Issues/PRs

NA

What does this implement/fix? Explain your changes.

  • Made it possible to build tslib/react and optuna_dashboard by rollup
  • Updated some import statements in order to reduce warning messages during rollup in optuna_dashboard

@porink0424 porink0424 changed the title Feat/rollup tslib Build packages by Rollup Jul 12, 2024
@c-bata c-bata self-assigned this Jul 17, 2024
@porink0424 porink0424 changed the title Build packages by Rollup Build tslib/react by Rollup Jul 19, 2024
@porink0424 porink0424 marked this pull request as ready for review July 19, 2024 03:27
@porink0424 porink0424 changed the title Build tslib/react by Rollup Build tslib/react by Rollup instead of tsc Jul 19, 2024
@porink0424 porink0424 changed the title Build tslib/react by Rollup instead of tsc Build packages by Rollup instead of tsc Jul 19, 2024
@porink0424 porink0424 marked this pull request as draft July 19, 2024 03:44
@porink0424 porink0424 mentioned this pull request Jul 19, 2024
1 task
@c-bata c-bata closed this Aug 7, 2024
@porink0424 porink0424 deleted the feat/rollup-tslib branch August 9, 2024 01:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants