Use tanstack table in tslib #882
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #882 +/- ##
=======================================
Coverage 69.51% 69.51%
=======================================
Files 35 35
Lines 2375 2375
=======================================
Hits 1651 1651
Misses 724 724 ☔ View full report in Codecov by Sentry. |
| ) | ||
| const [pagination, setPagination] = React.useState<PaginationState>({ | ||
| pageIndex: 0, | ||
| pageSize: 50, |
There was a problem hiding this comment.
You set pageSize here 50 as constant, but how about receiving initialRowsPerPage as a prop and using that value here, as current DataGrid does?
|
|
||
| export const TrialTable: FC<{ | ||
| study: Optuna.Study | ||
| initialRowsPerPage?: number | ||
| }> = ({ study, initialRowsPerPage }) => { | ||
| }> = ({ study }) => { |
There was a problem hiding this comment.
Following the comment above, maybe you need to restore initialRowsPerPage prop here as well.
It would be also good in terms of not having to make destructive changes to the existing interface.
|
@porink0424 |
keisuke-umezawa
force-pushed
the
feature/tanstack-table-tslib
branch
from
68513f5 to
f747a55
Compare
Contributor License Agreement
This repository (
optuna-dashboard) and Goptuna share common code.This pull request may therefore be ported to Goptuna.
Make sure that you understand the consequences concerning licenses and check the box below if you accept the term before creating this pull request.
Reference Issues/PRs
NA
What does this implement/fix? Explain your changes.
Tanstack table was introduced in optuna-dashboard by #846.
This PR will also introduce it in tslib.