Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix package-lock.json to build on Linux environment #870

Merged
merged 3 commits into from
Apr 24, 2024

Conversation

c-bata
Copy link
Member

@c-bata c-bata commented Apr 24, 2024

Contributor License Agreement

This repository (optuna-dashboard) and Goptuna share common code.
This pull request may therefore be ported to Goptuna.
Make sure that you understand the consequences concerning licenses and check the box below if you accept the term before creating this pull request.

  • I agree this patch may be ported to Goptuna by other Goptuna contributors.

Reference Issues/PRs

I'm not sure why but npm run watch became raising the following error on Linux environments after merging #864.

$ npm run watch

> [email protected] watch
> NODE_ENV=development TYPESCRIPT_LOADER=esbuild-loader webpack --watch

= = = = = = = = = = = = = = = = = = =
DEVELOPMENT BUILD
esbuild-loader
= = = = = = = = = = = = = = = = = = =
asset bundle.js 1.76 KiB [compared for emit] (name: main) 1 related asset
./ts/index.tsx 39 bytes [built] [1 error]

ERROR in ./ts/index.tsx
Module build failed (from ./node_modules/esbuild-loader/dist/index.cjs):
Error: The package "@esbuild/linux-x64" could not be found, and is needed by esbuild.

If you are installing esbuild with npm, make sure that you don't specify the
"--no-optional" or "--omit=optional" flags. The "optionalDependencies" feature
of "package.json" is used by esbuild to install the correct binary executable
for your current platform.
    at generateBinPath (/home/cbata/go/src/github.com/optuna/optuna-dashboard/optuna_dashboard/node_modules/esbuild/lib/main.js:1921:15)
    at esbuildCommandAndArgs (/home/cbata/go/src/github.com/optuna/optuna-dashboard/optuna_dashboard/node_modules/esbuild/lib/main.js:1991:33)
    at ensureServiceIsRunning (/home/cbata/go/src/github.com/optuna/optuna-dashboard/optuna_dashboard/node_modules/esbuild/lib/main.js:2163:25)
    at transform (/home/cbata/go/src/github.com/optuna/optuna-dashboard/optuna_dashboard/node_modules/esbuild/lib/main.js:2049:37)
    at Object.ESBuildLoader (/home/cbata/go/src/github.com/optuna/optuna-dashboard/optuna_dashboard/node_modules/esbuild-loader/dist/index.cjs:77:33)

What does this implement/fix? Explain your changes.

Re-generate package-lock.json by rm -rf node_modules package-lock.json && npm install.

@c-bata c-bata merged commit 480ac9e into optuna:main Apr 24, 2024
10 checks passed
@c-bata c-bata deleted the fix-package-lock.json branch April 24, 2024 05:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants