-
-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Filter DataGrid rows by multiple conditions #700
Conversation
I'll make this PR ready for review once #698 will be merged. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #700 +/- ##
==========================================
+ Coverage 63.77% 65.23% +1.46%
==========================================
Files 35 35
Lines 2280 2284 +4
==========================================
+ Hits 1454 1490 +36
+ Misses 826 794 -32 ☔ View full report in Codecov by Sentry. |
@nabenabe0928 Could you review this PR? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your PR!
I made some minor comments")
Btw, shall we add the tests for filterChoices in another PR or shall we do it in this PR?
For the local test, I used the following: import optuna
import numpy as np
def create_study_with_various_trials(storage: str) -> None:
rng = np.random.RandomState(42)
def _objective_intermediate_values(trial: optuna.Trial) -> float:
x = trial.suggest_categorical("x", choices=["a", "b", "c"])
rnd = rng.random()
if rnd < 0.25:
trial.report(trial.number, step=0)
trial.report(trial.number + 1, step=1)
elif rnd < 0.5:
trial.report(trial.number, step=0)
raise optuna.TrialPruned()
elif rnd < 0.75:
raise optuna.TrialPruned()
else:
raise ValueError("Unexpected Error.")
return 0.0
study = optuna.create_study(study_name="various-trials", storage=storage)
study.optimize(_objective_intermediate_values, n_trials=40, catch=(Exception,))
create_study_with_various_trials(storage=storage) |
Co-authored-by: Shuhei Watanabe <[email protected]>
@nabenabe0928 Thank you for your review. I applied your suggestions.
Yes, let us work on it in another PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the changes, LGTM!
Contributor License Agreement
This repository (
optuna-dashboard
) and Goptuna share common code.This pull request may therefore be ported to Goptuna.
Make sure that you understand the consequences concerning licenses and check the box below if you accept the term before creating this pull request.
Reference Issues/PRs
Refs #696
What does this implement/fix? Explain your changes.
Filter DataGrid rows by multiple conditions.