Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support constraints in slice plot #688

Merged
merged 1 commit into from
Nov 9, 2023

Conversation

knshnb
Copy link
Member

@knshnb knshnb commented Nov 8, 2023

Contributor License Agreement

This repository (optuna-dashboard) and Goptuna share common code.
This pull request may therefore be ported to Goptuna.
Make sure that you understand the consequences concerning licenses and check the box below if you accept the term before creating this pull request.

  • I agree this patch may be ported to Goptuna by other Goptuna contributors.

Reference Issues/PRs

This PR adds constraint support to the dashboard, which was previously introduced in optuna: optuna/optuna#4906.

What does this implement/fix? Explain your changes.

  • plot infeasible trials in gray with the label "Infeasible Trial"

@knshnb knshnb marked this pull request as ready for review November 8, 2023 09:46
@knshnb knshnb added the enhancement New feature or request label Nov 8, 2023
Copy link

codecov bot commented Nov 8, 2023

Codecov Report

Merging #688 (5076818) into main (2c50b5a) will not change coverage.
Report is 3 commits behind head on main.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #688   +/-   ##
=======================================
  Coverage   62.88%   62.88%           
=======================================
  Files          35       35           
  Lines        2250     2250           
=======================================
  Hits         1415     1415           
  Misses        835      835           

📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

@HideakiImamura
Copy link
Member

@not522 Could you review this PR?

Copy link
Member

@HideakiImamura HideakiImamura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I confirmed that the change of this PR generates the following figure in the dashboard.
Screenshot 2023-11-09 at 9 07 46

@HideakiImamura HideakiImamura removed their assignment Nov 9, 2023
Copy link
Member

@not522 not522 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@not522 not522 merged commit bdeb664 into optuna:main Nov 9, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants