Use the same implementation of getAxisInfo for rank and contour plot #680
+170
−256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #680 +/- ##
==========================================
+ Coverage 62.88% 64.35% +1.46%
==========================================
Files 35 35
Lines 2250 2250
==========================================
+ Hits 1415 1448 +33
+ Misses 835 802 -33 ☔ View full report in Codecov by Sentry. |
|
@not522 Could you review this PR? |
keisuke-umezawa
force-pushed
the
fix/refactor-rank-plot
branch
from
7b1866c to
e60663f
Compare
|
The test fails with optuna==2.10.0. Could you check it? |
|
@HideakiImamura |
HideakiImamura
approved these changes
Dec 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributor License Agreement
This repository (
optuna-dashboard) and Goptuna share common code.This pull request may therefore be ported to Goptuna.
Make sure that you understand the consequences concerning licenses and check the box below if you accept the term before creating this pull request.
Reference Issues/PRs
To follow up #656
What does this implement/fix? Explain your changes.
Use the same implementation of getAxisInfo for rank and contour plot