-
-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add color scale setting #632
Merged
Merged
Changes from 10 commits
Commits
Show all changes
33 commits
Select commit
Hold shift + click to select a range
48df828
Create base UI
gen740 45f5813
add color palettes
gen740 30e0ac5
Update
gen740 f95ac90
Merge branch 'main' into add_color_scale_setting
gen740 8863946
Implement color theme
gen740 167f631
Change all plotly template.
gen740 85e3a1f
Merge branch 'main' into add_color_scale_setting
gen740 2006dd0
Merge branch 'main' into add_color_scale_setting
gen740 5e3898b
revert `optuna_dashboard/index.html`
gen740 45db781
Delete unnecessary blank line.
gen740 49fa791
Fix typo
gen740 70752dd
Merge branch 'main' into add_color_scale_setting
gen740 0d4f0b4
Update optuna_dashboard/ts/components/Settings.tsx
gen740 0346f66
Format
gen740 5f5efb4
Merge branch 'main' into add_color_scale_setting
gen740 59a251a
Merge branch 'main' into add_color_scale_setting
gen740 651ac76
Update optuna_dashboard/ts/components/Settings.tsx
gen740 4ec52d2
Delete grid color scale
gen740 1a61af6
Apply changes to GraphRank.tsx
gen740 0d5db75
Rename PlotlyDarkTheme to PlotlyCloroTemplates
gen740 5c6baf7
Delete unnecessary console.log
gen740 cdb8c48
format
gen740 54706ea
Add coloTheme to useEffect watch list
gen740 b99b877
Update setting UI to Popover
gen740 af6f5cb
Use Modal instead of Popover
gen740 fc3dda0
Merge branch 'main' into add_color_scale_setting
gen740 ab31b63
format
gen740 1525e37
Delete "getColorTemplate" Function
gen740 280f6a5
Merge branch 'main' into add_color_scale_setting
gen740 2a7cf2c
[Delete] Delete `prettier-ignore`
gen740 2c07611
Merge branch 'main' into add_color_scale_setting
gen740 9229780
Apply format
gen740 4b74031
Update biome.json
gen740 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -28,6 +28,8 @@ import Brightness4Icon from "@mui/icons-material/Brightness4" | |
import Brightness7Icon from "@mui/icons-material/Brightness7" | ||
import TableViewIcon from "@mui/icons-material/TableView" | ||
import RateReviewIcon from "@mui/icons-material/RateReview" | ||
import SettingsIcon from "@mui/icons-material/Settings" | ||
|
||
import MenuIcon from "@mui/icons-material/Menu" | ||
import GitHubIcon from "@mui/icons-material/GitHub" | ||
import OpenInNewIcon from "@mui/icons-material/OpenInNew" | ||
|
@@ -46,6 +48,7 @@ export type PageId = | |
| "trialTable" | ||
| "trialList" | ||
| "note" | ||
| "settings" | ||
| "preferenceHistory" | ||
| "graph" | ||
|
||
|
@@ -300,6 +303,19 @@ export const AppDrawer: FC<{ | |
<ListItemText primary="Note" sx={styleListItemText} /> | ||
</ListItemButton> | ||
</ListItem> | ||
<ListItem key="Settings" disablePadding sx={styleListItem}> | ||
<ListItemButton | ||
component={Link} | ||
to={`${URL_PREFIX}/studies/${studyId}/settings`} | ||
sx={styleListItemButton} | ||
selected={page === "settings"} | ||
> | ||
<ListItemIcon sx={styleListItemIcon}> | ||
<SettingsIcon /> | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Is it better with ColorLens? |
||
</ListItemIcon> | ||
<ListItemText primary="Settings" sx={styleListItemText} /> | ||
</ListItemButton> | ||
</ListItem> | ||
</List> | ||
)} | ||
<Box sx={{ flexGrow: 1 }} /> | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This settings seem to be shared among every study. In that case, the url should be
${URL_PREFIX}/settings
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I understand the situation, and you want to remember study_id by url, and go back to previous study page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about using pop-up to show setting page? I roughly created my example here, although it is very early implementation and needs improvement.
Some reasons:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, the place of setting should be below because it is for setting for all pages, imo.
You can see this example here