feat: add ssz test for more types #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GrapeBaBa
reviewed
Nov 1, 2024
src/spec_tests/ssz_static/root.zig
Outdated
| // test cases for all phases | ||
| const CommonUnion = union { | ||
| const commonUnion = union { |
There was a problem hiding this comment.
It seems usually we should use upper start char for types
GrapeBaBa
reviewed
Nov 1, 2024
src/spec_tests/ssz_static/root.zig
Outdated
| }; | ||
|
|
||
| const forks = [_][]const u8{ "phase0", "altair", "bellatrix", "capella", "deneb", "electra" }; |
There was a problem hiding this comment.
Can it be function in ForkType in consensus/types file
There was a problem hiding this comment.
this is the dir name of test
fearlessfe
force-pushed
the
testcases
branch
2 times, most recently
from
ac9872b to
84063e7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related issue #3
add ssz test for more types