Add ssz spec test #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GrapeBaBa
reviewed
Oct 29, 2024
| # Update deps target to include nasm check | ||
| deps: check_nasm | ||
| @echo "Installing dependencies" | ||
| @git submodule update --init --recursive | ||
| @cd bls && make -f Makefile.onelib ETH_CFLAGS=-DBLS_ETH LIB_DIR=lib | ||
|
|
||
| mkdir -p consensus-spec-tests |
There was a problem hiding this comment.
Use a separate the task would be better such as if someone want to build it in local but don't want to do spec tests.
GrapeBaBa
reviewed
Oct 29, 2024
build.zig.zon
Outdated
| // .url = "https://github.com/Raiden1411/zabi/archive/79c77aa4a39d41ed50033fd922f4d37c0f0638bb.tar.gz", | ||
| // .hash = "122095aaf2d09e3286bf8b00b773b65c1632639de6c5005de881754df7c04efc7e98", | ||
| // } }, | ||
| .dependencies = .{ .yaml = .{ .url = "git+https://github.com/optimism-java/zig-yaml.git#7a7c5162230bb08f73ec22a063010ed7c76ccded", .hash = "1220a6d7148f7777d997ee663e0efe0fb9c57a38658ea164bcd267e8391c3ce0aa87" } }, |
There was a problem hiding this comment.
Why snappy/ssz directly imported but this lib outside, should we unify them？
GrapeBaBa
reviewed
Oct 29, 2024
src/spec_tests/ssz_static/root.zig
Outdated
| } | ||
| } | ||
| if (!hasSubDir) { | ||
| // std.debug.print("currentPath: {s}\n", .{currentPath}); |
GrapeBaBa
reviewed
Oct 29, 2024
| const Yaml = @import("yaml").Yaml; | ||
|
|
||
| const gpa = testing.allocator; | ||
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add spec test for type
Forkrelated #3