Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

downgrade typebox #2639

Merged
merged 1 commit into from
Jan 2, 2024
Merged

downgrade typebox #2639

merged 1 commit into from
Jan 2, 2024

Conversation

niclim
Copy link
Contributor

@niclim niclim commented Jan 2, 2024

🍗 Description

What does this PR do? Anything folks should know?

The binary build was broken because 0.32.0 typebox uses the exports field in package.json to build support for ESM, but pkg does not respect it vercel/pkg#1873

📚 References

Links to relevant docs (Notion, Twist, GH issues, etc.), if applicable.

👹 QA

How can other humans verify that this PR is correct?

@niclim niclim requested a review from notnmeyer January 2, 2024 20:14
@niclim niclim requested a review from acunniffe as a code owner January 2, 2024 20:14
@niclim niclim added this pull request to the merge queue Jan 2, 2024
@notnmeyer
Copy link
Contributor

notnmeyer commented Jan 2, 2024

we've seen enough "X broke the binaries" issues that im feeling extra motivated to get some sort of testing around them. annoyingly (and my fault), we dont have an atomic release process. the binaries and container image wait for the npm packages to release first, then the binaries start. its a remnant of how things were added on over time.

what would be great is building all the artifacts first, doing whatever verification, and then publishing everything.

@niclim was this failing during optic run? we could do something like https://github.com/opticdev/bookstore-example/blob/main/.github/workflows/optic.yml between building the binaries and publishing them. that won't do anything for atomicity, but could at least prevent us from pushing broken binary builds.

Merged via the queue into main with commit 5b35001 Jan 2, 2024
1 check passed
@niclim niclim deleted the fix/binary branch January 2, 2024 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants