KEA: custom DNS for reservation #7310 - basic GUI and conf implementa… #7564
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
June 27, 2024 16:26
…lementation. Problem: neither is_array() nor is_iterable() which seems to be the right function call recognises the itarable $node content. Additional this is implemented in Base models so it has to be proofed to be interoperable with all other model usages.
…lementation. Problem: stream import is done correctly with all variables. But in validation step the new variables were thrown out and I have no clue where to add them as "valid". Additional this is implemented in Base model so it has to be proofed to be interoperable with all other model usages or rewritten to other function call.
|
|
Thanks for hint - wasn't checking last 3 weeks for updates of this problem. |
AdSchellevis
force-pushed
the
master
branch
5 times, most recently
from
6586a65 to
607e32a
Compare
…r_reservation_#7310
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…tion.
First implementation try for #7310
NOT FOR PRODUCTION USAGE yet.
Basic GUI / conf implementation works "as usual" ... with several "copied" bugs where I am wondering where QA/community checks were failing to find this basic misbehavior yet since months:
the content of ALL option_data is GONE after save
(this commit can be yet the only "stable" one)
I was wondering why in subnet4 a dedicated "data-option" array was setup.
Especially for "plain" CSV export/import and also "array dump to json" it doesn't make much sense.
But maybe it's a workaround for the "not nested arrays implemented" code checks in which I trapped while trying to implement export/import CSV enhancments for reservations.
The import and exports handles modifies basic model templates so it must be used very carefully/checked against all other usages of this models. But I am not a PHP dev but more administrator with basic programming skills... ^^