-
Notifications
You must be signed in to change notification settings - Fork 136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Tekton-backed Kubeflow Pipelines #1554
Conversation
Need to figure out the implications of the required SCC, probably move some of the contents of this PR around to different folders too. |
01fa5b9
to
966a211
Compare
/hold |
Okay I'm going through the manifests. So off the bat, all the cluster-scope manifests should go to the See the readme docs in that link on how to structure it. You might find this tool usefule for this https://github.com/larsks/halberd Remember you have to pull these into the Having said that, there are a lot of questionable manifests here ... in my opinion, at least for what it seems to be asking. And I will try to go through them. |
This PR is installing csi-s3:
I don't think we want to just install a new CSI that can mount s3 storage w/o a separate discussion on why we should add it... Do we need this? Which component needs it? Can we use the s3 we already have? I see that this all results in a new storage class |
@anishasthana I also noticed in your demo deployed on the dev cluster that the I skimmed through the manifests/configfiles/secrets and I also don't see any reference to the cache-deployer service. (could be I just missed it) |
So there's a
Both of these require s3 creds from a secret, we can sub our own s3 for these. |
66d29cd
to
db820f9
Compare
We disabled creds-init by setting the |
|
4d471d4
to
e42daf8
Compare
Signed-off-by: Anish Asthana <[email protected]>
e42daf8
to
2e298d2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: HumairAK The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Closes operate-first/support#435
Signed-off-by: Anish Asthana [email protected]