Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: upgrade nodepool crd to v1beta2 #2266

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

feat: upgrade nodepool crd to v1beta2

39c82bc
Select commit
Loading
Failed to load commit list.
Open

feat: upgrade nodepool crd to v1beta2 #2266

feat: upgrade nodepool crd to v1beta2
39c82bc
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Jan 10, 2025 in 0s

45.36% (+0.17%) compared to 9ba1d5e

View this Pull Request on Codecov

45.36% (+0.17%) compared to 9ba1d5e

Details

Codecov Report

Attention: Patch coverage is 71.83099% with 40 lines in your changes missing coverage. Please review.

Project coverage is 45.36%. Comparing base (9ba1d5e) to head (39c82bc).

Files with missing lines Patch % Lines
...er/webhook/nodepool/v1beta2/nodepool_validation.go 73.68% 20 Missing and 5 partials ⚠️
pkg/yurtmanager/webhook/server.go 0.00% 6 Missing ⚠️
pkg/apis/apps/v1beta2/default.go 0.00% 3 Missing ⚠️
...nager/webhook/nodepool/v1beta2/nodepool_handler.go 0.00% 3 Missing ⚠️
pkg/apis/apps/v1beta2/groupversion_info.go 0.00% 2 Missing ⚠️
pkg/apis/apps/v1beta2/nodepool_conversion.go 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #2266      +/-   ##
==========================================
+ Coverage   45.18%   45.36%   +0.17%     
==========================================
  Files         422      430       +8     
  Lines       28779    28920     +141     
==========================================
+ Hits        13005    13119     +114     
- Misses      14460    14483      +23     
- Partials     1314     1318       +4

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov