proposal: reuse list/watch requests in the nodepool for reducing clou… #2226
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2226 +/- ##
==========================================
- Coverage 45.24% 45.18% -0.06%
==========================================
Files 422 422
Lines 28779 28779
==========================================
- Hits 13021 13005 -16
- Misses 14447 14460 +13
- Partials 1311 1314 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
| 2. Different leader election strategies can be supported, such as random, mark, etc. | ||
| - random: controller select one ready node as leader at random. | ||
| - mark: controller select one ready node as leader from nodes that are specified by labelselector. | ||
| 3. Leader Yurthub will start to list/watch pool scope metadata from control-plane and store on local memory for sharing. |
There was a problem hiding this comment.
When we refer to local memory are we talking about RAM or Disk?
There was a problem hiding this comment.
local memory here is about RAM.
rambohe-ch
force-pushed
the
add-resue-nodepool-list-watch-requests
branch
from
d1f64b4 to
2a63a31
Compare
…d-edge network traffic Signed-off-by: rambohe-ch <[email protected]>
rambohe-ch
force-pushed
the
add-resue-nodepool-list-watch-requests
branch
from
2a63a31 to
d9b8c22
Compare
|
|
/LGTM |
|
|
||
| This field is used only when LeaderElectionStrategy is mark. controller will elect leader from nodes that filtered by this label selector. | ||
|
|
||
| + Spec.PoolScopeMetadata: []schema.GroupVersionKind [Allowed to change] |
There was a problem hiding this comment.
I think we can use a string slice here, formatted as 'group/version/kind'. It just requires adding a parser to process it. This way, users can enable this ability by specifying the group, groupVersion, or a specific gvk in the nodepool.
poolScopeMetadata:
- v1
- discovery.k8s.io/v1Additionally, string slice would be more user-friendly. How do you think?
There was a problem hiding this comment.
I think that []metav1.GroupVersionKind slice maybe more understandable for end users, and if we formated as 'group/version/kind' string slice, end users need to know the format at first before configure pool scope metadata.
so I prefer []metav1.GroupVersionKind slice to formated []string slice.
What type of PR is this?
/kind feature
What this PR does / why we need it:
add a proposal to reuse list/watch requests in the nodepool for reducing cloud-edge network traffic.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?
other Note