Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: update contributing.md #2210

Merged
merged 1 commit into from
Dec 10, 2024
Merged

doc: update contributing.md #2210

merged 1 commit into from
Dec 10, 2024

Conversation

YTGhost
Copy link
Member

@YTGhost YTGhost commented Nov 30, 2024

What type of PR is this?

/kind documentation

What this PR does / why we need it:

Which issue(s) this PR fixes:

#2187

Special notes for your reviewer:

Does this PR introduce a user-facing change?


other Note

CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
Copy link

codecov bot commented Dec 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 45.24%. Comparing base (7763e7c) to head (7f65b55).
Report is 48 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff             @@
##           master    #2210       +/-   ##
===========================================
- Coverage   58.93%   45.24%   -13.70%     
===========================================
  Files         210      404      +194     
  Lines       18968    27811     +8843     
===========================================
+ Hits        11179    12583     +1404     
- Misses       6707    13997     +7290     
- Partials     1082     1231      +149     
Flag Coverage Δ
unittests 45.24% <ø> (-13.70%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rambohe-ch rambohe-ch added approved approved lgtm lgtm labels Dec 10, 2024
@rambohe-ch
Copy link
Member

/LGTM

@rambohe-ch rambohe-ch merged commit 8eed50b into master Dec 10, 2024
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved approved lgtm lgtm
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants