Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat:fix error log format in cache manager #1791

Merged
merged 1 commit into from
Nov 14, 2023

Conversation

NewKeyTo
Copy link
Contributor

What type of PR is this?
/kind good-first-issue
/kind feature

What this PR does / why we need it:
fix error log format in cache manager.

Which issue(s) this PR fixes:
Fixes #1776

@openyurt-bot openyurt-bot added kind/good-first-issue kind/good-first-issue kind/feature kind/feature labels Nov 13, 2023
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@openyurt-bot
Copy link
Collaborator

Welcome @NewKeyTo! It looks like this is your first PR to openyurtio/openyurt 🎉

@openyurt-bot openyurt-bot added the size/XS size/XS: 0-9 label Nov 13, 2023
@YTGhost
Copy link
Member

YTGhost commented Nov 13, 2023

/rerun

Copy link

codecov bot commented Nov 13, 2023

Codecov Report

Merging #1791 (8a59b83) into master (118f6a3) will increase coverage by 0.00%.
Report is 1 commits behind head on master.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #1791   +/-   ##
=======================================
  Coverage   52.22%   52.23%           
=======================================
  Files         172      172           
  Lines       20840    20840           
=======================================
+ Hits        10883    10885    +2     
+ Misses       8999     8998    -1     
+ Partials      958      957    -1     
Flag Coverage Δ
unittests 52.23% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
pkg/yurthub/cachemanager/cache_manager.go 71.54% <100.00%> (ø)

... and 1 file with indirect coverage changes

Copy link
Member

@YTGhost YTGhost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openyurt-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: NewKeyTo, rambohe-ch, YTGhost

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openyurt-bot openyurt-bot added the approved approved label Nov 14, 2023
@rambohe-ch rambohe-ch merged commit f0e8511 into openyurtio:master Nov 14, 2023
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved approved kind/feature kind/feature kind/good-first-issue kind/good-first-issue lgtm lgtm size/XS size/XS: 0-9
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[feature request]fix error log format in cache manager
4 participants