-
Notifications
You must be signed in to change notification settings - Fork 407
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
improve rabc settings of secrets for yurt-manager component #1742
improve rabc settings of secrets for yurt-manager component #1742
Conversation
@rambohe-ch: GitHub didn't allow me to assign the following users: your_reviewer. Note that only openyurtio members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
3aca9e4
to
d04e580
Compare
Codecov Report
@@ Coverage Diff @@
## master #1742 +/- ##
==========================================
+ Coverage 50.74% 50.80% +0.06%
==========================================
Files 165 165
Lines 19258 19258
==========================================
+ Hits 9772 9784 +12
+ Misses 8566 8555 -11
+ Partials 920 919 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
d04e580
to
47c4f33
Compare
47c4f33
to
5b314d3
Compare
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
@YTGhost PTAL |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rambohe-ch, YTGhost The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind enhancement
What this PR does / why we need it:
In order to improve the security setting for yurt-manager component, improve secret resource rbac settings for yurt-manager as following:
update
andget
. remove other verbs like create and delete.Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?
other Note