Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal for yurtappspreader #1736

Closed

Conversation

vie-serendipity
Copy link
Member

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespace from that line:
/kind bug
/kind documentation
/kind enhancement
/kind good-first-issue
/kind feature
/kind question
/kind design
/sig ai
/sig iot
/sig network
/sig storage

/kind documentation

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?


other Note

@openyurt-bot
Copy link
Collaborator

@vie-serendipity: GitHub didn't allow me to assign the following users: your_reviewer.

Note that only openyurtio members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespace from that line:
/kind bug
/kind documentation
/kind enhancement
/kind good-first-issue
/kind feature
/kind question
/kind design
/sig ai
/sig iot
/sig network
/sig storage

/kind documentation

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?


other Note

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openyurt-bot openyurt-bot added the kind/documentation kind/documentation label Oct 17, 2023
@openyurt-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: vie-serendipity
To complete the pull request process, please assign huangyuqi
You can assign the PR to them by writing /assign @huangyuqi in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openyurt-bot openyurt-bot added the size/L size/L: 100-499 label Oct 17, 2023
@codecov
Copy link

codecov bot commented Oct 17, 2023

Codecov Report

Merging #1736 (02eaec8) into master (fbd5058) will not change coverage.
The diff coverage is n/a.

❗ Current head 02eaec8 differs from pull request most recent head 7e75254. Consider uploading reports for the commit 7e75254 to get more accurate results

@@           Coverage Diff           @@
##           master    #1736   +/-   ##
=======================================
  Coverage   50.81%   50.81%           
=======================================
  Files         165      165           
  Lines       19254    19254           
=======================================
  Hits         9783     9783           
  Misses       8554     8554           
  Partials      917      917           
Flag Coverage Δ
unittests 50.81% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@rambohe-ch
Copy link
Member

@vie-serendipity as we discussed in proposal #1890 , we will use yurtappset v1beta1 to cover yurtappset v1alpha1, yurtappdaemon and yurtappoverrider, so the proposal in this pull request is overlapped with yurtappset v1beta1.

and i will close this pull request directly, and please feel free to reopen or create new pull reqeusts.

@rambohe-ch rambohe-ch closed this Jan 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/documentation kind/documentation size/L size/L: 100-499
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants