-
Notifications
You must be signed in to change notification settings - Fork 407
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Proposal for yurtappspreader #1736
Proposal for yurtappspreader #1736
Conversation
@vie-serendipity: GitHub didn't allow me to assign the following users: your_reviewer. Note that only openyurtio members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: vie-serendipity The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov Report
@@ Coverage Diff @@
## master #1736 +/- ##
=======================================
Coverage 50.81% 50.81%
=======================================
Files 165 165
Lines 19254 19254
=======================================
Hits 9783 9783
Misses 8554 8554
Partials 917 917
Flags with carried forward coverage won't be shown. Click here to find out more. |
Kudos, SonarCloud Quality Gate passed! |
@vie-serendipity as we discussed in proposal #1890 , we will use yurtappset v1beta1 to cover yurtappset v1alpha1, yurtappdaemon and yurtappoverrider, so the proposal in this pull request is overlapped with yurtappset v1beta1. and i will close this pull request directly, and please feel free to reopen or create new pull reqeusts. |
What type of PR is this?
/kind documentation
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?
other Note