Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add convert webhook for gateway #1724

Merged
merged 1 commit into from
Oct 8, 2023

Conversation

River-sh
Copy link
Contributor

@River-sh River-sh commented Oct 8, 2023

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespace from that line:
/kind enhancement
/kind feature
/sig network

What this PR does / why we need it:

add convert webhook for gateway

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?


other Note

@openyurt-bot
Copy link
Collaborator

@River-sh: GitHub didn't allow me to assign the following users: your_reviewer.

Note that only openyurtio members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespace from that line:
/kind enhancement
/kind feature
/sig network

What this PR does / why we need it:

add convert webhook for gateway

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?


other Note

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openyurt-bot openyurt-bot added the size/XL size/XL: 500-999 label Oct 8, 2023
@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 8, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 3 Code Smells

No Coverage information No Coverage information
6.2% 6.2% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@codecov
Copy link

codecov bot commented Oct 8, 2023

Codecov Report

Merging #1724 (4d3cc05) into master (8b94570) will decrease coverage by 0.82%.
Report is 11 commits behind head on master.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1724      +/-   ##
==========================================
- Coverage   52.46%   51.64%   -0.82%     
==========================================
  Files         162      168       +6     
  Lines       19091    20063     +972     
==========================================
+ Hits        10016    10362     +346     
- Misses       8150     8716     +566     
- Partials      925      985      +60     
Flag Coverage Δ
unittests 51.64% <ø> (-0.82%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 33 files with indirect coverage changes

@rambohe-ch
Copy link
Member

/lgtm

@openyurt-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rambohe-ch, River-sh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openyurt-bot openyurt-bot added the approved approved label Oct 8, 2023
@openyurt-bot openyurt-bot added the lgtm lgtm label Oct 8, 2023
@openyurt-bot openyurt-bot merged commit df21f74 into openyurtio:master Oct 8, 2023
13 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved approved lgtm lgtm size/XL size/XL: 500-999
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants