[transforms] Fix simplification patterns for stablehlo.(and|or)
#2638
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes an issue in `stablehlo-aggressive-simplification` where `%1` in the below would get replaced by `%arg0`: ``` %0 = stablehlo.constant dense<1> : tensor<2xi32> %1 = stablehlo.and %0, %arg0 : tensor<2xi32> ``` The pattern was checking whether `%0` is equal to `0b1` and was only tested on bools. A similar bug existed for `stablehlo.and`. Fixed by just making sure the constant is integer with all bits set to 1.
|
Fixes #2633 |
sdasgup3
approved these changes
Nov 25, 2024
GleasonK
approved these changes
Nov 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an issue in
stablehlo-aggressive-simplificationwhere%1inthe below would get replaced by
%arg0:The pattern was checking whether
%0is equal to0b1and wasonly tested on bools. A similar bug existed for
stablehlo.and. Fixedby just making sure the constant is integer with all bits set to 1.