Change API for EAD items to support large numbers #333
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
I had a hunch I'd done this before already: this was my first PR (https://github.com/openwsn-berkeley/lakers/pull/100/files). But too much has changed, so the old PR is not actionable any more. It did more than just change the type (it made its details private); that's still something worth doing, but maybe better deferred to be done together with other restructurings like supporting multiple EAD items. |
|
Rebased onto main to fix CI; I think this is ready for review. |
|
Latest fix also adjusts for the language bindings that did not get tested as part of |
|
Almost ready to merge, can you add |
The set of supported values is not changed, but the API is changed so that the implementation can be fixed without an extra breaking change.
|
Fixed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The set of supported values is not changed, but the API is changed so that the implementation can be fixed without an extra breaking change.
Didn't run any special tests, let's see if CI is happy. (Should be a no-brainer though).