-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release: rust 0.6.2 and python 0.3.3 #292
Conversation
includes bug fixes with python wheel distribution and in turn facilitates integration with libraries that depend on lakers-python, such as aiocoap actually, the rust side doesn't have updates, but since the triggers to publish python wheels are on github actions, I am just bumping all the versions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks a lot.
[edit: CI is doing CI things … missed a version?]
Seems to be something in the Actions environment, tried to re-run 0.6.1 and got the same errors. |
I've been trying to reproduce that locally, but that fails for lack of PSA, and GitHub runners are not exactly something to easily run locally. This:
looks almost like a code generator started spewing debug output into the generated code. But those are generated by bindgen. As presumably the tests run successfully locally, could you try checking in your Cargo.lock file? By now, that's the default anyway |
Yeah, I had |
I'm getting completely different errors on the PSA side; updating bindgen could help, trying that. |
I've taken the liberty to push a commit onto your branch to run the CI of this PR again with the update from malishav/rust-psa-crypto#1 Unless Mališa is currently on vacation or there's another reason that PR can't go in quickly, I'd rather avoid having that in the released version (so I can delete the branch again) -- but then again, it's a patched crate, and those are not part of what gets to crates.io anyway. |
Hrmpf, that fixed my local build, but not the CI case. At least I know now why it's on line 3: the top lines are |
I can now reproduce locally: things worked on stable but broke on nightly. I'm tempted to just fix this by editing out the "rewriting static" that's clearly a leftover println somewhere where I can't trace it. What I do know so far is that it does affect rust-psa-crypto. |
The issue is tracked to bindgen: rust-lang/rust-bindgen#2852 |
Wow, and that's a really fresh issue. Thanks for digging and finding it. Let's wait a bit and see if they fix it somewhat fast. Or else I can try to specify a previous rust version in the CI. |
… but ultimately came from rust-lang/rustfmt#6210. It is already fixed, but it'll take a day or two to get into the nightlies. As a whole I think the best way to go is to revert my change (updating rust-psa-crypto's bindgen is still good but not critical for here), pin the nightly instead, and revert that pin after this is out. |
Today's nightly has a broken rustfmt; pinning it makes CI work and avoids users running into similar issues.
All green now; the only change compared to your original branch is now the fixed nightly version, and that the example's nightly version is symlinked to the toolchain version to avoid missing one when changing back. |
Great! Thanks for fixing that. |
includes bug fixes with python wheel distribution
and in turn facilitates integration with libraries that depend on lakers-python, such as aiocoap
actually, the rust side doesn't have updates,
but since the triggers to publish python wheels are on github actions, I am just bumping all the versions