Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use owned credential type #189

Merged
merged 5 commits into from
Jan 12, 2024
Merged

Use owned credential type #189

merged 5 commits into from
Jan 12, 2024

Conversation

geonnave
Copy link
Collaborator

No description provided.

@geonnave geonnave force-pushed the use-owned-credential-type branch 2 times, most recently from 81f5dd0 to edfe62a Compare January 10, 2024 18:26
@geonnave
Copy link
Collaborator Author

My initial goal was to get rid of IdCredOwned, and replace it with CredentialRPK, but then fields such as CredentialRPK.value would have to be Optional, spreading around runtime checks that would otherwise not be needed.

So I've decided to just keep IdCredOwned as is.

Thus, the main change in this PR is the addition of the CredentialRPK type which owns its contents and provide static access to fields such as public_key and id_cred, thus removing one potential source of panics from the protocol core.

@geonnave geonnave force-pushed the use-owned-credential-type branch from 8729997 to e4cc190 Compare January 10, 2024 18:44
@geonnave geonnave added the enhancement New feature or request label Jan 10, 2024
@geonnave geonnave force-pushed the use-owned-credential-type branch from e4cc190 to e0addd3 Compare January 12, 2024 10:38
@geonnave geonnave merged commit e87542d into openwsn-berkeley:main Jan 12, 2024
27 checks passed
@geonnave geonnave deleted the use-owned-credential-type branch January 12, 2024 10:56
@geonnave geonnave mentioned this pull request Jan 12, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@geonnave