[fix] Fix create_default_topology condition check #421 #422
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix if condition checking if the default topology should be created. Fixes openwisp#421
pandafy
requested changes
Dec 27, 2024
There was a problem hiding this comment.
Thank you for contributing @keviiin38! I have a suggest to improve this patch futher. Please see my comment below.
Co-authored-by: Gagan Deep <[email protected]>
|
Sorry for the small fixes... I should have run the |
nemesifier
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix if condition checking if the default topology should be created.
Checklist
Reference to Existing Issue
Closes #421
Description of Changes
Currently the
ifcondition returnsTrueeven if the variableUSE_OPENWISP_TOPOLOGYis set toFalse.This is due to the fact that the value returned is
"False", which evaluates toTruein Python.Screenshot
n/a